feat: use commit-check-action to check PR title#90
Draft
shenxianpeng wants to merge 2 commits into
Draft
Conversation
Replace the committed-based PR title check with our own commit-check-action to eat our own dogfood. - Remove Rust toolchain installation (rustup, cargo-binstall, committed) - Add commit-check.toml config mirroring the existing committed.toml rules - Simplify to a single checkout (action auto-discovers config in .github/) - Keep cspell spell check as a separate step
shenxianpeng
commented
Jun 22, 2026
Member
Author
|
This PR is not ready and still needs to think about how to make it work as expected. I will come back when I have time. |
Contributor
We could have also just used My only main concern is adhering to conventional commits standards. This is because generating a changelog or release notes (via So, if [commit]
# https://www.conventionalcommits.org
conventional_commits = truemeans it enforces |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been maintaining commit-check for about 4 years now. It's mature enough to use the commit-check-action in their CI.
This PR eats my own dog food :)
What changed
Before: The check-pr-title job in pre-commit.yml installed a full Rust toolchain (rustup, cargo-binstall, committed) just to validate one PR title.
After: Uses commit-check-action with
pr-title: true. The action discovers.github/commit-check.tomlautomatically — no extra setup needed.Also added
commit-check.tomlto mirror the rules we had incommitted.toml.Diff
.github/)+27 -30netNot in this PR
.github/committed.tomlis kept for now (can clean up later)commit-check.tomlor useinherit_from— that's a follow-up